refactor: enhance Faraday Response with helper methods

lib/scalingo/api/client.rb

@@ -1,4 +1,6 @@
 require "scalingo/token_holder"
+require "scalingo/faraday/response"
+require "active_support/core_ext/hash"
 
 module Scalingo
   module API

lib/scalingo/faraday/response.rb

@@ -0,0 +1,29 @@
+require "faraday"
+require "faraday/response"
+
+# Some additional methods for Faraday::Response in order to enhance expressiveness
+module Faraday
+  class Response
+    # @deprecated Use {#success?} instead
+    def successful?
+      success?
+    end
+
+    # @deprecated Use {#body} instead
+    def data
+      body
+    end
+
+    def client_error?
+      RaiseError::ClientErrorStatuses.include?(status)
+    end
+
+    def server_error?
+      RaiseError::ServerErrorStatuses.include?(status)
+    end
+
+    def error?
+      !success?
+    end
+  end
+end