Switch responses to pure-ish faraday #57
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces breaking changes to the gem; readme and changelog will be updated subsequently.
In this PR, the
Scalingo::API::Response
is removed altogether. Instead, we use regular faraday objects, although with some minor additions:meta
as a property on the responseOn top of this, the
unpack
mechanism is now automated. If the response is successful and there is a single root key after dealing with the metadata, we automatically extract it. ThisEach of those two functions is dealt with using faraday middlewares - both could be extract from this lib, but with so few code lines in each of them, the value is really low