Rework the DB api access #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aurelien-reeves-scalingo
requested changes
Apr 15, 2024
|
Updated the changelog. Can the readme wait a little bit? I have other PRs incoming and would rather change it all at once |
aurelien-reeves-scalingo
approved these changes
Apr 15, 2024
If there's a demand for it. The download statistics of the gem are low enough that it might be worth spending the time on it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per-commit review is slightly more readable.
This PR reworks the db api architecture, mostly by removed the "global" access there was. Before this PR, the DB Api was exposed at the same "level" of other API clients, but it's not a good fit: all other APIs require authenticating as a user (except for guest endpoints), while the DB api require authenticating as a user then as a specific database.
To accomodate this change, api clients need to keep track of which region they're targetting (this allows a regional API client to instantiate the db api client in the same region; the response for
tokendoesn't relay that information).Slight rename of files/classes as well.