Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always raise on errors #63

Merged
merged 9 commits into from
Apr 15, 2024
Merged

Always raise on errors #63

merged 9 commits into from
Apr 15, 2024

Conversation

ksol
Copy link
Contributor

@ksol ksol commented Apr 15, 2024

This PR re-orients the gem towards raising exception when something goes wrong (while previously it was configurable).

This means raising exceptions on error responses, but also when the token is missing and when it is expired.

The code is smaller/simpler as a result, which is always nice.

Side tasks:

  • token expiration is read directly from the token instead of assuming 1h (and leaving room to customize it). this adds a dependency on jwt
  • addressable was missing in the dependencies of the gem (it was introduced a couple of PRs ago)
  • some dead code/comments were still around
  • changelog/readme was updated

This also marks the gem as 4.0 beta 1, as the largest internal work is now complete

@ksol ksol self-assigned this Apr 15, 2024
@ksol ksol merged commit ce0dbee into master Apr 15, 2024
6 checks passed
@ksol ksol deleted the feat/config branch April 15, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants