Merge pull request #339 from seb3s/patch-7

allow a start error to properly propagate
ScenicFramework · Dec 7, 2023 · d3f1e6b · d3f1e6b
2 parents 0cdf1bd + 5d407bb
commit d3f1e6b
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/lib/scenic.ex b/lib/scenic.ex
@@ -61,13 +61,17 @@ defmodule Scenic do
   def start_link(vps \\ [])
 
   def start_link(vps) when is_list(vps) do
-    {:ok, pid} = Supervisor.start_link(__MODULE__, nil, name: :scenic)
+    case Supervisor.start_link(__MODULE__, nil, name: :scenic) do
+      {:ok, pid} ->
+        # start the default ViewPort
+        Enum.each(vps, &Scenic.ViewPort.start(&1))
 
-    # start the default ViewPort
-    Enum.each(vps, &Scenic.ViewPort.start(&1))
+        # return the original start_link value
+        {:ok, pid}
 
-    # return the original start_link value
-    {:ok, pid}
+      error ->
+        error
+    end
   end
 
   # --------------------------------------------------------