find should always return a full primitive #332
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes
Graph.find/2
to pass a full primitive instead of just the primitive's id to the finder function.Also adds a
Graph.find_by_id/2
method to preserve the api, primarily forGraph.modify
and for any one else who may be calling find.Motivation and Context
According to the docs, this should pass a full primitive.
Types of changes
This could potentially break other code using
Graph.find/2
currently expecting a primitive id.