Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find should always return a full primitive #332

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

vacarsu
Copy link
Contributor

@vacarsu vacarsu commented Sep 22, 2023

Description

Changes Graph.find/2 to pass a full primitive instead of just the primitive's id to the finder function.

Also adds a Graph.find_by_id/2 method to preserve the api, primarily for Graph.modify and for any one else who may be calling find.

Motivation and Context

According to the docs, this should pass a full primitive.

Types of changes

This could potentially break other code using Graph.find/2 currently expecting a primitive id.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant