Fix tests on Elixir 1.15 #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starts running tests on Elixir 1.15 with OTP 26 The map ordering change in OTP 26 caused many tests to break because they were implicitly relying on a not guaranteed order. Adds machete to add a sorted_list test helper (instead of changing many assertions to be split across two statements)
crertel
approved these changes
Sep 25, 2023
|
Yeah I really like having |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Starts running tests on Elixir 1.15 with OTP 26
The map ordering change in OTP 26 caused many tests to break because they were implicitly relying on a not guaranteed order.
Adds machete to add a sorted_list test helper (instead of changing many assertions to be split across two statements)
Motivation and Context
Allows running the tests on the most recent version of Elixir and OTP
Types of changes
not work as expected)
but make things better)
Checklist