Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow start error to properly propagate #339

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Allow start error to properly propagate #339

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions lib/scenic.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,13 +64,17 @@ defmodule Scenic do
def start_link(vps \\ [])

def start_link(vps) when is_list(vps) do
{:ok, pid} = Supervisor.start_link(__MODULE__, nil, name: :scenic)
case Supervisor.start_link(__MODULE__, nil, name: :scenic) do
{:ok, pid} ->
# start the default ViewPort
Enum.each(vps, &Scenic.ViewPort.start(&1))

# start the default ViewPort
Enum.each(vps, &Scenic.ViewPort.start(&1))
# return the original start_link value
{:ok, pid}

# return the original start_link value
{:ok, pid}
error ->
error
end
end

# --------------------------------------------------------
Expand Down
Loading