[Resolve #4] Fail gracefully on bad input #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given a call to this filter like:
```jinja
policy_document:
{{ updated_policy_document | unquote_resolvers(output_indent=4, trim=True) }}
```
If the input does not contain a list of a dict, the filter fails confusingly like:
```
File "/app/sceptre/sceptre/config/reader.py", line 509, in _render
raise SceptreException(message) from err
sceptre.exceptions.SceptreException: s3-bucket-generic.yaml - unquote_resolvers - ('cannot represent an object', Undefined)
Templating vars saved to: /tmp/vars_fdup6pqa
```
The filter should fail gracefully in this scenario.
zaro0508
requested changes
Jun 17, 2024
There was a problem hiding this comment.
this PR seems fine to me however the pre-commit job is failing.
Also this repo is still setup to build and release with CircleCI. Sceptre has migrated away from CircleCi to GH actions therefore unit tests jobs for this project are no longer running either. You might want to enable unit tests in GH actions. For an example on how that's done you can take a look at the sceptre-resolver-template test and release workflows
|
Not certain, but I think I've done everything I can from my side! |
|
@alexharv074 i have updated this PR with master, but I think i made a mistake by not changing the |
zaro0508
approved these changes
Jun 18, 2024
zaro0508
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given a call to this filter like:
policy_document: {{ updated_policy_document | unquote_resolvers(output_indent=4, trim=True) }}If the input does not contain a list or a dict, the filter fails confusingly like:
This adds code to fail gracefully in this scenario.
Also updates dependencies to get the tests passing again.