-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Resolve #1212] Conditional Stacks via "ignore" and "obsolete" #1229
[Resolve #1212] Conditional Stacks via "ignore" and "obsolete" #1229
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I agree with this approach therefore I have left reviewing the details until we can flush it out a bit more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jfalkenstein approving on the basis that I don't have any objection to it and can't see any issue with it after reading your excellent docs and a once over read of the code without fully understanding it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally LGTM, just one more minor request and i think we are good to go.
This feature adds two new Stack configurations, a new option on
launch
and a new command (prune
):ignore
will cause thelaunch
command to completely ignore the Stack; It will be neither created, nor updated, nor deleted. If the Stack currently exists on AWS, it will stay as it is. If the stack does not exist on AWS, it will not be created.obsolete
stacks function likeignore
d. ones, but will be deleted when pruned (see below)launch
command now has a--prune
option. Whenlaunch --prune
is invoked, all obsolete stacks on the command path will deleted first before the rest of the deployment proceeds.prune
command will delete all obsolete stacks in the entire project (irrespective of any command path). This is a simple way to clean up potentially multiple stacks that need to be deleted.This PR adds the feature described in #1212 and addresses the spirit of #1193 .
The basic idea here is you could do something like:
This feature addresses two needs:
sceptre launch
when it isn't ready or certain Jinja Logic determines that it should not be launched.PR Checklist
[Resolve #issue-number]
.make test
) are passing.pre-commit run --all-files
).and description in grammatically correct, complete sentences.
Approver/Reviewer Checklist
Other Information
Guide to writing a good commit