Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

block public access on template bucket #728

Closed
wants to merge 1 commit into from

Conversation

cornerman
Copy link
Contributor

Sceptre creates an S3-Bucket for cloudformation templates (if template_bucket_name is set in the stack-group config). If the bucket does not exist, it will be created by sceptre automatically. This bucket is only for referencing cloudformation templates in the deployment and does not need to be public.

To assure that there is no public access, this PR configures newly created template buckets to block public access.

PR Checklist

  • Wrote a good commit message & description [see guide below].
  • Commit message starts with [Resolve #issue-number].
  • Added/Updated unit tests.
  • Added/Updated integration tests (if applicable).
  • All unit tests (make test) are passing.
  • Used the same coding conventions as the rest of the project.
  • The new code passes flake8 (make lint) checks.
  • The PR relates to only one subject with a clear title.
    and description in grammatically correct, complete sentences.

Approver/Reviewer Checklist

  • Before merge squash related commits.

Other Information

Guide to writing a good commit

@ngfgrant
Copy link
Contributor

Hi @cornerman

Going to close this see #730 for explanation. Like the idea though!

Thanks
Niall

@ngfgrant ngfgrant closed this Jun 10, 2019
@cornerman cornerman deleted the private-template-bucket branch June 10, 2019 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants