Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add split screen support #171

Draft
wants to merge 2 commits into
base: sc
Choose a base branch
from
Draft

Conversation

Sinofine
Copy link

@Sinofine Sinofine commented Jan 12, 2023

With android's multi windows support, it's easy to split two activities into two windows, which benefits tablet users.

Screen shots:

Screenshot_20230112_163144_SchildiChat dbg
Screenshot_20230112_163343_SchildiChat dbg

also I provided multi chat windows option for windowed mode android (like samsung's DeX mode)

Screenshot_20230112_180024_One UI Home

Those options are opt-in by default for compatibility.

Screenshot_20230112_180112_One UI Home

reference: https://developer.android.com/guide/topics/large-screens/multi-window-support

@SpiritCroc
Copy link
Member

Wow, that looks great! I'll try to test it in the coming weeks.

@SpiritCroc
Copy link
Member

Just did some testing, initial thoughts:

Don't know what to expect from non-tablets, but if I enable tablet mode on my Android 11 phone and do the following:

  • go to room list
  • open a room
  • press home
  • open the app from recents
  • press back

Then it gets me to my launcher instead back to the room list.
After that, whenever I re-open the app from recents, I get a blank screen, and I need to close the app with back or by killing it to get it working again by starting it from launcher.
The multiwindow setting doesn't make a difference for that matter.
Since you put the feature in labs, that's probably not a blocker, but it would be nice to have some narrower device requirements to detect if the feature will be useful on the particular device, and hide and force-disable it if that's not the case.

On my Android 11 tablet, it behaves the same as with my phone. Could it be a problem of my custom ROM not being configured properly to support these features, or is Android 11 too old? On a foldable emulator with Android 13, split screen works, but I haven't gotten the windowed mode to work, is there a system setting that I need to enable?

@Sinofine
Copy link
Author

Sinofine commented Jan 13, 2023

I've tested the feature on my samsung tab s7 with android 13, it works flawlessly; however using my phone (MIUI13, an custom ROM with android 12 inside) it doesn't work well (as multiple windows are not well supported on phone devices). Thus I might think that it's well to hide it in phone devices.

Furthermore, I'll test the feature with some more tablet devices, as in google's guide there are not major changes done after android 10.

@Sinofine Sinofine marked this pull request as draft February 10, 2023 01:07
@Sinofine
Copy link
Author

Sinofine commented Feb 10, 2023

Screenshot_20230210_092842_SchildiChat dbg

my recent works.

@ThatOneCalculator
Copy link

Any update on this?

@Sinofine
Copy link
Author

Sinofine commented Apr 1, 2023

Any update on this?

recently I'm working on this approach

seems that google thinks it's better than multi window approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants