Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve IRC layout for SchildiChat #268

Closed
wants to merge 0 commits into from
Closed

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Oct 29, 2024

Closes SchildiChat/matrix-react-sdk#21

This PR is essentially a retry of SchildiChat/matrix-react-sdk#21 and intends to improve the IRC layout for SchildiChat, fixing several issues logged on the upstream repository as well. For detailed explanation, please check the superseded PR of mine.

As I am not quite sure of the workflow for the lite branch yet, please let me know what else to be done (for example, is creating a PR for matrix-react-sdk with the commit necessary?)

Upstream SC
Message Panel 5 5_1
Hidden event via Devtools 2 2_1
Alignment 8 8_1
upstream.mp4
sc.mp4

@luixxiul
Copy link
Contributor Author

Please feel free to add edits as needed :)

@SpiritCroc
Copy link
Member

Some quick notes without having looked into these in detail yet:

  • qg / su-ex is our timeline layout CSS expert and still busy with life, so maybe I take a look at it and drop it as soon as any conflict arises, but I certainly will not maintain this in the long run (I don't use IRC layout after all). I assume it's fine that if whenever I drop it, you rebase it... not sure, the workflow hasn't been thought out yet and will require coordinating with su-ex.
  • It just came to my attention that matrix-react-sdk was merged with the element-web repo upstream (finally), which means that I need to redo some patching again... hopefully later this week, but no guarantees. Until then I won't accept any PRs for sure, so you'll probably need to rebase then as well.

@luixxiul
Copy link
Contributor Author

qg / su-ex is our timeline layout CSS expert and still busy with life, so maybe I take a look at it and drop it as soon as any conflict arises, but I certainly will not maintain this in the long run (I don't use IRC layout after all).

FWIW the actual code related to the IRC layout and EventTile on the upstream has been mostly created by me, and apparently the file itself has not been quite changed since a couple of years, so I assume this PR will not create a huge conflict once rebasing is completed, unless the upstream will decide to replace the current UI as a whole for some reason.

matrix-react-sdk was merged with the element-web repo upstream (finally)

Honestly I could not really understand what has been the intention of having it managed under Matrix Foundation in the first place...

@SpiritCroc
Copy link
Member

FWIW the actual code related to the IRC layout and EventTile on the upstream has been mostly created by me, and apparently the file itself has not been quite changed since a couple of years, so I assume this PR will not create a huge conflict once rebasing is completed, unless the upstream will decide to replace the current UI as a whole for some reason.

Cool, good to know!

@luixxiul
Copy link
Contributor Author

I noticed this would break alignment of emote messages. Fixing it.

@luixxiul
Copy link
Contributor Author

I've closed the PR accidentally. Will create another one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants