Add new Farmland Mode with light level for crops #55
Conversation
There was a problem hiding this comment.
Looks very good overall, thank you for working on this!
There are some nit-picks and suggestions, see the comments for further details.
I highly appreciate the help! Feel free to further work on it as much as you like, and then I'll take it from there.
I already have ideas how to integrate the farmland mode as a kind of "sub-overlay", so don't worry too much about rendering stuff, I'll make it so that the rendering gets adjusted depending on whether the "main overlay" is carpet mode, number mode etc.
Again, thanks for the help!
common/src/main/java/dev/schmarrn/lighty/mode/BoringCrossMode.java
Outdated
Show resolved
Hide resolved
Alveel
changed the title
Alveel
force-pushed
the
light-level-for-crops
branch
from
8032201 to
feefa26
Compare
|
Ready for review! |
Alveel
changed the title
There was a problem hiding this comment.
Sorry to have kept you waiting!
I really like the work you've done here, well done!
I suggest a small change for LightyColors.getGrowthARGB that represents the growth conditions based on lighting a little bit better. Based on my testing, the change makes it so that:
- If plants can grow, green
- If plants cannot grow, orange
- If plants unplant themself, red
Please also take a look at the change if you want to and verify that I didn't mess something up 🙃
When the change is applied, I see no further issues and I'll be happy to merge this PR!
Added light level functionality for farmland/crops.
Also added a new separate farmland mode. I must note that about 95% of the farmland mode code is identical to carpet mode.