Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse more code in Initialization Process of ODE models #1108

Open
2 tasks done
HenrZu opened this issue Aug 15, 2024 · 0 comments · May be fixed by #1163
Open
2 tasks done

Reuse more code in Initialization Process of ODE models #1108

HenrZu opened this issue Aug 15, 2024 · 0 comments · May be fixed by #1163
Labels
class::improvement Cleanup that doesn't affect functionality loc::backend This issue concerns the C++ backend implementation. model::ode This issue concerns any kind of ODE-based model.

Comments

@HenrZu
Copy link
Contributor

HenrZu commented Aug 15, 2024 •
edited
Loading

Motivation / Current Behaviour

Reuse more code, e.g., set_divi_data (in ode_secir) and a set_divi_data (ode_secirvvs) only need a different ModelType.
Consider:

  1. changing the interfaces of these read_sth functions,

  2. adding some more (code) documentation and

  3. maybe making them more modular,

Enhancement description

less code would make it easier to maintain.

Additional context

No response

Checklist

  • Attached labels, especially loc:: or model:: labels.
  • Linked to project
@HenrZu HenrZu added loc::backend This issue concerns the C++ backend implementation. model::ode This issue concerns any kind of ODE-based model. class::improvement Cleanup that doesn't affect functionality labels Aug 15, 2024
@HenrZu HenrZu mentioned this issue Aug 15, 2024
Merged
12 tasks
@HenrZu HenrZu mentioned this issue Nov 13, 2024
Merged
12 tasks
@HenrZu HenrZu linked a pull request Dec 13, 2024 that will close this issue
1108 Reuse more code in Initialization Process of ODE models #1163
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
class::improvement Cleanup that doesn't affect functionality loc::backend This issue concerns the C++ backend implementation. model::ode This issue concerns any kind of ODE-based model.
Projects
MEmilio: Equation-Based-Models Development
Status: Product Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

1108 Reuse more code in Initialization Process of ODE models SciCompMod/memilio
1 participant
@HenrZu