-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
323 SECIRTS model with waning immunity #963
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #963 +/- ##
==========================================
- Coverage 96.98% 96.92% -0.07%
==========================================
Files 142 148 +6
Lines 11873 13558 +1685
==========================================
+ Hits 11515 13141 +1626
- Misses 358 417 +59 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a quick look at a few files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great rework, there are still some fairly large functions, but they are a lot more focused. Most requested changes are about small cleanups.
There are a lot of uncovered lines for error handling, especially in ode_secirts/parameters_io.h. While it would be better to test these functions extensively, I think this is okay, for now. But make a note that this can be improved upon.
Co-authored-by: reneSchm <[email protected]>
Co-authored-by: reneSchm <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this PR is in a pretty good state now. Unless @mknaranja wants to have a final look, we can merge it soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really only did an incomplete review but as @reneSchm did I full one I am OK with merging if we briefly address the open items.
Co-authored-by: Martin J. Kühn <[email protected]>
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
If need be, add additional information and what the reviewer should look out for in particular:
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)
closes #323