Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust memilio-generation for flow models and automatic differentiation #1019

Open
2 tasks done
MaxBetzDLR opened this issue Apr 26, 2024 · 1 comment · May be fixed by #1153
Open
2 tasks done

Adjust memilio-generation for flow models and automatic differentiation #1019

MaxBetzDLR opened this issue Apr 26, 2024 · 1 comment · May be fixed by #1153
Assignees
@dr2001dlr
Labels
class::improvement Cleanup that doesn't affect functionality class::performance Performance related issues loc::python interface This issue concerns the python interface to the backend implementation.

Comments

@MaxBetzDLR
Copy link
Member

MaxBetzDLR commented Apr 26, 2024 •
edited by mknaranja
Loading

Motivation / Current Behaviour

Introduction of flows in issue #511 and the added usage of templates to a lot of classes in issue #894 changed the behavior of the generation package. This results into wrongly generated code. As a temporary fix the reference test data was adjusted.

Additionally the test is slow due to recompiling the c++ code.

Enhancement description

Update memilio-generation to work with new code structure and patterns

Additional context

No response

Checklist

  • Attached labels, especially loc:: or model:: labels.
  • Linked to project
@MaxBetzDLR MaxBetzDLR added loc::python interface This issue concerns the python interface to the backend implementation. class::improvement Cleanup that doesn't affect functionality class::performance Performance related issues labels Apr 26, 2024
@MaxBetzDLR MaxBetzDLR self-assigned this Apr 26, 2024
@MaxBetzDLR MaxBetzDLR mentioned this issue Apr 26, 2024
Merged
11 tasks
@reneSchm
Copy link
Member

Recompilation could be circumvented by reusing the skbuild directory produced by setup.py. That is, instead of creating a temporary build directory and calling cmake on it from within the test itself, we can probably just set build_dir during the skbuild setup (e.g. via a config file). To keep the build/test split for the CI, we can probably use upload-/download-artifact actions to copy the _skbuild directory from build to test.

@mknaranja mknaranja changed the title Adjust memilio-generation for flow models Adjust memilio-generation for flow models and automatic differentiation Apr 26, 2024
@dr2001dlr dr2001dlr assigned dr2001dlr and unassigned MaxBetzDLR Nov 4, 2024
@dr2001dlr dr2001dlr linked a pull request Dec 2, 2024 that will close this issue
1019 Adjust memilio-generation for flow models and automatic differentiation #1153
Open
12 tasks
@dr2001dlr dr2001dlr linked a pull request Dec 2, 2024 that will close this issue
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dr2001dlr dr2001dlr

Labels
class::improvement Cleanup that doesn't affect functionality class::performance Performance related issues loc::python interface This issue concerns the python interface to the backend implementation.
Projects
MEmilio: Equation-Based-Models Development
Status: 🏗 Development
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

1019 Adjust memilio-generation for flow models and automatic differentiation SciCompMod/memilio
3 participants
@reneSchm @MaxBetzDLR @dr2001dlr