Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1019 Adjust memilio-generation for flow models and automatic differentiation #1153

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

dr2001dlr
Copy link
Collaborator

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

-Scanner now checks for Flowmodel and Compartmentalmodel
-pymio includes fixed in template_string
-config.json does not need age_group, simulation and parameterset_wrapper annymore (scanner is setting those)
-added simulate and simulate_flows
-added interpolate_simulation_result and interpolate_ensemble_results
-added scalartype in intermediate_representation to set a datatype for bindings

If need be, add additional information and what the reviewer should look out for in particular:

-Check if the bindings are correct

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

Closes #1019

…ls, fixed pymio includes, added draw_sample binding, fixed flow_simulation and simulation bindings. Fixed the substitution in the generator. Added scalartype in intermediate_representation to set the type.
@dr2001dlr dr2001dlr self-assigned this Dec 2, 2024
@dr2001dlr dr2001dlr linked an issue Dec 2, 2024 that may be closed by this pull request
2 tasks
@dr2001dlr dr2001dlr added class::feature A feature to be implemented for some part of the software status::in progress This issue is in progess. class::improvement Cleanup that doesn't affect functionality labels Dec 2, 2024
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.95%. Comparing base (ff9df1e) to head (49e5ecc).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1153      +/-   ##
==========================================
+ Coverage   96.88%   96.95%   +0.07%     
==========================================
  Files         140      148       +8     
  Lines       11502    13715    +2213     
==========================================
+ Hits        11144    13298    +2154     
- Misses        358      417      +59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
class::feature A feature to be implemented for some part of the software class::improvement Cleanup that doesn't affect functionality status::in progress This issue is in progess.
Projects
Development

Successfully merging this pull request may close these issues.

Adjust memilio-generation for flow models and automatic differentiation
1 participant