-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1019 Adjust memilio-generation for flow models and automatic differentiation #1153
Open
dr2001dlr
wants to merge
10
commits into
main
Choose a base branch
from
1019-adjust-memilio-generation-for-flow-models-and-automatic-differentiation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
1019 Adjust memilio-generation for flow models and automatic differentiation #1153
dr2001dlr
wants to merge
10
commits into
main
from
1019-adjust-memilio-generation-for-flow-models-and-automatic-differentiation
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ls, fixed pymio includes, added draw_sample binding, fixed flow_simulation and simulation bindings. Fixed the substitution in the generator. Added scalartype in intermediate_representation to set the type.
2 tasks
dr2001dlr
added
class::feature
A feature to be implemented for some part of the software
status::in progress
This issue is in progess.
class::improvement
Cleanup that doesn't affect functionality
labels
Dec 2, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1153 +/- ##
==========================================
+ Coverage 96.88% 96.95% +0.07%
==========================================
Files 140 148 +8
Lines 11502 13715 +2213
==========================================
+ Hits 11144 13298 +2154
- Misses 358 417 +59 ☔ View full report in Codecov by Sentry. |
…nerated when there is no AgeGroup in intermediate_representation.
…ATE, changed comment in utility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
class::feature
A feature to be implemented for some part of the software
class::improvement
Cleanup that doesn't affect functionality
status::in progress
This issue is in progess.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
-Scanner now checks for Flowmodel and Compartmentalmodel
-pymio includes fixed in template_string
-config.json does not need age_group, simulation and parameterset_wrapper annymore (scanner is setting those)
-added simulate and simulate_flows
-added interpolate_simulation_result and interpolate_ensemble_results
-added scalartype in intermediate_representation to set a datatype for bindings
If need be, add additional information and what the reviewer should look out for in particular:
-Check if the bindings are correct
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)
Closes #1019