Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DynamicNPI implementation delay as parameter. #982

Closed
mknaranja opened this issue Apr 2, 2024 · 0 comments · Fixed by #984
Closed

Add DynamicNPI implementation delay as parameter. #982

mknaranja opened this issue Apr 2, 2024 · 0 comments · Fixed by #984
Assignees
@mknaranja @HenrZu
Labels
class::improvement Cleanup that doesn't affect functionality loc::backend This issue concerns the C++ backend implementation. model::ode This issue concerns any kind of ODE-based model.

Comments

@mknaranja
Copy link
Member

In https://bmcinfectdis.biomedcentral.com/articles/10.1186/s12879-022-07302-9, we considered different delays in NPI implementation which was hardcoded and can be found in:

https://github.com/SciCompMod/memilio/blob/8ddb863051a43028c7d0fcdacdd1176db64ee488/cpp/models/ode_secirvvs/model.h#L649C16-L649C30

This value should be made a parameter and made available for other models too.
@mknaranja mknaranja added loc::backend This issue concerns the C++ backend implementation. model::ode This issue concerns any kind of ODE-based model. class::improvement Cleanup that doesn't affect functionality labels Apr 2, 2024
@mknaranja mknaranja self-assigned this Apr 2, 2024
@mknaranja mknaranja linked a pull request Apr 2, 2024 that will close this issue
982 Make NPI delay implementation a parameter, set it and harmonize model advance functions #984
Merged
12 tasks
@jubicker jubicker moved this from Product Backlog to 👀 Review in MEmilio: Equation-Based-Models Development Apr 18, 2024
@jubicker jubicker moved this from 👀 Review to 🏗 Development in MEmilio: Equation-Based-Models Development Apr 18, 2024
@HenrZu HenrZu moved this from 🏗 Development to 👀 Review in MEmilio: Equation-Based-Models Development Jun 13, 2024
@HenrZu HenrZu self-assigned this Jun 28, 2024
@github-project-automation github-project-automation bot moved this from 👀 Review to ✅ Done (Sprint) in MEmilio: Equation-Based-Models Development Sep 16, 2024
@mknaranja mknaranja mentioned this issue Dec 5, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mknaranja mknaranja

@HenrZu HenrZu

Labels
class::improvement Cleanup that doesn't affect functionality loc::backend This issue concerns the C++ backend implementation. model::ode This issue concerns any kind of ODE-based model.
Projects
MEmilio: Equation-Based-Models Development
Status: Done (Total)
Milestone
No milestone
2 participants
@mknaranja @HenrZu