Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1057 data generation for GNNs #1090

Open
wants to merge 34 commits into
base: main
Choose a base branch
from
Open

Conversation

AgathaSchmidt
Copy link
Member

@AgathaSchmidt AgathaSchmidt commented Aug 6, 2024

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • generate data for GNN for all 400 counties using the graph-ODE model
    --> without dampings
    --> with dampings

If need be, add additional information and what the reviewer should look out for in particular:

  • correct use of the graph-ODE model

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

@AgathaSchmidt AgathaSchmidt linked an issue Aug 6, 2024 that may be closed by this pull request
4 tasks
@AgathaSchmidt AgathaSchmidt requested a review from HenrZu August 6, 2024 08:39
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.44%. Comparing base (9ee0b56) to head (d9110e5).
Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1090      +/-   ##
==========================================
+ Coverage   96.23%   96.44%   +0.21%     
==========================================
  Files         128      135       +7     
  Lines       10867    11286     +419     
==========================================
+ Hits        10458    10885     +427     
+ Misses        409      401       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@HenrZu HenrZu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for the great work :)
In addition to the comments, it is particularly noticeable that a lot of code exists twice (or multiple times) here. We already have data generation functions and there are functions that are used in every file. We should create a central file for general functions and then import it. This makes it much space for potential errors + easier to test/maintain

bar.finish()

if save_data:
num_groups = int(np.asarray(data['inputs']).shape[2] / 8)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check your format on save settings again. The files are indented one position too far and generally a lot of formatting is displayed. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GNN data generation
2 participants