-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1057 data generation for GNNs #1090
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1090 +/- ##
==========================================
+ Coverage 96.23% 96.44% +0.21%
==========================================
Files 128 135 +7
Lines 10867 11286 +419
==========================================
+ Hits 10458 10885 +427
+ Misses 409 401 -8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for the great work :)
In addition to the comments, it is particularly noticeable that a lot of code exists twice (or multiple times) here. We already have data generation functions and there are functions that are used in every file. We should create a central file for general functions and then import it. This makes it much space for potential errors + easier to test/maintain
pycode/memilio-surrogatemodel/memilio/surrogatemodel/GNN/data_generation_nodamp.py
Show resolved
Hide resolved
pycode/memilio-surrogatemodel/memilio/surrogatemodel/GNN/data_generation_nodamp.py
Outdated
Show resolved
Hide resolved
pycode/memilio-surrogatemodel/memilio/surrogatemodel/GNN/data_generation_nodamp.py
Outdated
Show resolved
Hide resolved
pycode/memilio-surrogatemodel/memilio/surrogatemodel/GNN/data_generation_nodamp.py
Outdated
Show resolved
Hide resolved
pycode/memilio-surrogatemodel/memilio/surrogatemodel/GNN/data_generation_nodamp.py
Outdated
Show resolved
Hide resolved
pycode/memilio-surrogatemodel/memilio/surrogatemodel/GNN/data_generation_nodamp.py
Outdated
Show resolved
Hide resolved
bar.finish() | ||
|
||
if save_data: | ||
num_groups = int(np.asarray(data['inputs']).shape[2] / 8) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check your format on save settings again. The files are indented one position too far and generally a lot of formatting is displayed. :)
pycode/memilio-surrogatemodel/memilio/surrogatemodel/GNN/data_generation_nodamp.py
Outdated
Show resolved
Hide resolved
pycode/memilio-surrogatemodel/memilio/surrogatemodel/GNN/data_generation_nodamp.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Henrik Zunker <[email protected]>
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
--> without dampings
--> with dampings
If need be, add additional information and what the reviewer should look out for in particular:
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)