Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1123 Update getPopulationData.test_total_population() to account for 2023 population data #1126

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Jonasjjj96
Copy link

@Jonasjjj96 Jonasjjj96 commented Sep 17, 2024

Changes and Information

Fix: Mismatch in total population due to 2023 data update

The newly released population data for 2023 contains only data from 2023, causing a mismatch in the total population when compared with previous years. This results in an error being thrown during the population data validation process.

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

Fix: Mismatch in total population due to 2023 data update

The newly released population data for 2023 contains only data from 2023, causing a mismatch in the total population when compared with previous years. This results in an error being thrown during the population data validation process.
@Jonasjjj96 Jonasjjj96 changed the title Fix: Update getPopulationData.py to account for 2023 population data 1123 Update getPopulationData.test_total_population() to account for 2023 population data Sep 17, 2024
@Jonasjjj96
Copy link
Author

Pull Request 1124 could solve this issue

@Jonasjjj96 Jonasjjj96 marked this pull request as ready for review September 17, 2024 09:53
@patricklnz patricklnz added the duplicate This issue or pull request already exists label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants