Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

506 build static and shared libraries #507

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

xsaschako
Copy link
Member

@xsaschako xsaschako commented Dec 13, 2022

Merge Request - GuideLine Checklist

Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.

Checks by code author:

Always to be checked:

If functions were changed or functionality was added:

  • Tests for new functionality has been added
  • A local test was succesful

If new functionality was added:

  • There is appropriate documentation of your work. (use doxygen style comments)

If new third party software is used:

  • Did you pay attention to its license? Please remember to add it to the wiki after successful merging.

If new mathematical methods or epidemiological terms are used:

  • Are new methods referenced? Did you provide further documentation? Has the glossary been updated?

The following questions are addressed in the documentation if need be:

  • Developers (what did you do?, how can it be maintained?)

  • For users (how to use your work?)

  • For admins (how to install and configure your work?)

  • For documentation: Please write or update the Readme in the current working directory!

Checks by code reviewer(s):

  • Is the code clean of development artifacts e.g., unnecessary comments, prints, ...
  • The ticket goals for each associated issue are reached or problems are clearly addressed (i.e., a new issue was introduced).
  • There are appropriate unit tests and they pass.
  • The git history is clean and linearized for the merge request. All reviewers should squash commits and write a simple and meaningful commit message.
  • Coverage report for new code is acceptable.

closes #506
closes #647

@xsaschako xsaschako marked this pull request as draft December 15, 2022 15:23
@xsaschako xsaschako self-assigned this Mar 17, 2023
@xsaschako xsaschako force-pushed the 506-overhaul-cmakelist-for-constructing-shared-and-static-libraries-of-memilio branch 5 times, most recently from 678ace0 to 42c0bf8 Compare May 16, 2023 14:37
fixed googletest shared library and shared macro

Signed-off-by: Sascha Korf <[email protected]>

fix some cmake things

Signed-off-by: Sascha Korf <[email protected]>

add some cleanup

Signed-off-by: Sascha Korf <[email protected]>

cleanp some more

Signed-off-by: Sascha Korf <[email protected]>
@xsaschako xsaschako force-pushed the 506-overhaul-cmakelist-for-constructing-shared-and-static-libraries-of-memilio branch from 42c0bf8 to 6bbd94b Compare May 16, 2023 14:37
Signed-off-by: Sascha Korf <[email protected]>
@xsaschako xsaschako linked an issue May 17, 2023 that may be closed by this pull request
2 tasks
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e2e5dc7) 95.40% compared to head (f88c493) 92.06%.

❗ Current head f88c493 differs from pull request most recent head 54fa887. Consider uploading reports for the commit 54fa887 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #507      +/-   ##
==========================================
- Coverage   95.40%   92.06%   -3.35%     
==========================================
  Files         117       91      -26     
  Lines        9231     7084    -2147     
==========================================
- Hits         8807     6522    -2285     
- Misses        424      562     +138     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…ed-and-static-libraries-of-memilio

Signed-off-by: Sascha Korf <[email protected]>
…ed-and-static-libraries-of-memilio

Signed-off-by: Sascha Korf <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up CMake Files Overhaul cmakelist for constructing shared and static libraries of memilio
1 participant