-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
506 build static and shared libraries #507
Draft
xsaschako
wants to merge
9
commits into
main
Choose a base branch
from
506-overhaul-cmakelist-for-constructing-shared-and-static-libraries-of-memilio
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
506 build static and shared libraries #507
xsaschako
wants to merge
9
commits into
main
from
506-overhaul-cmakelist-for-constructing-shared-and-static-libraries-of-memilio
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xsaschako
force-pushed
the
506-overhaul-cmakelist-for-constructing-shared-and-static-libraries-of-memilio
branch
5 times, most recently
from
May 16, 2023 14:37
678ace0
to
42c0bf8
Compare
fixed googletest shared library and shared macro Signed-off-by: Sascha Korf <[email protected]> fix some cmake things Signed-off-by: Sascha Korf <[email protected]> add some cleanup Signed-off-by: Sascha Korf <[email protected]> cleanp some more Signed-off-by: Sascha Korf <[email protected]>
xsaschako
force-pushed
the
506-overhaul-cmakelist-for-constructing-shared-and-static-libraries-of-memilio
branch
from
May 16, 2023 14:37
42c0bf8
to
6bbd94b
Compare
Signed-off-by: Sascha Korf <[email protected]>
2 tasks
Signed-off-by: Sascha Korf <[email protected]>
…ed-and-static-libraries-of-memilio
…ed-and-static-libraries-of-memilio
…ed-and-static-libraries-of-memilio Signed-off-by: Sascha Korf <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #507 +/- ##
==========================================
- Coverage 95.40% 92.06% -3.35%
==========================================
Files 117 91 -26
Lines 9231 7084 -2147
==========================================
- Hits 8807 6522 -2285
- Misses 424 562 +138 ☔ View full report in Codecov by Sentry. |
…ed-and-static-libraries-of-memilio Signed-off-by: Sascha Korf <[email protected]>
…ed-and-static-libraries-of-memilio Signed-off-by: Sascha Korf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge Request - GuideLine Checklist
Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.
Checks by code author:
Always to be checked:
If functions were changed or functionality was added:
If new functionality was added:
If new third party software is used:
If new mathematical methods or epidemiological terms are used:
The following questions are addressed in the documentation if need be:
Developers (what did you do?, how can it be maintained?)
For users (how to use your work?)
For admins (how to install and configure your work?)
For documentation: Please write or update the Readme in the current working directory!
Checks by code reviewer(s):
closes #506
closes #647