Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

865 Resolve errors in getNPIData for fine resolution 0 and 1 #891

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

patricklnz
Copy link
Member

@patricklnz patricklnz commented Jan 15, 2024

Changes and Information

Please briefly list the changes made, additional Information and what the Reviewer should look out for:

Resolve errors for getNPIData.py for fine_resolution = 0,1

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)

Closes #865

@mknaranja mknaranja changed the title 865 getnpidata errors 865 Resolve errors in getNPIData for fine resolution 0 and 1 Feb 9, 2024
@patricklnz patricklnz requested a review from annawendler April 25, 2024 11:32
for i in range(num_counties)])
# 'bundesland' maps to stateID for DIVI, so rename it seperately here
df_npis_old.rename(
{'bundesland': dd.EngEng('state')}, axis=1, inplace=True)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When executing the script with fine_resolution=1 I get the error TypeError: 'dict' object is not callable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors in getNPIData.py
2 participants