Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

898 change test for valid transition distibution from ide model #913

Conversation

lenaploetzke
Copy link
Member

@lenaploetzke lenaploetzke commented Feb 2, 2024

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • Changed the index of a test in check_constraints for the ide model because the transitiondistribution S-> E is never used, so it does not have to have valid support. This can lead to unexpected errors if the function was set arbitrarily.

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

Closes #898

@lenaploetzke lenaploetzke added class::bug Bugs found in the software status::in review This issues is in review. model::ide This issue concerns any kind of integro differential equations-based model. loc::infrastructure General MEmilio Infrastructure related issues labels Feb 2, 2024
@lenaploetzke lenaploetzke self-assigned this Feb 2, 2024
@lenaploetzke lenaploetzke linked an issue Feb 2, 2024 that may be closed by this pull request
2 tasks
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6391c30) 95.88% compared to head (86f1133) 95.88%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #913   +/-   ##
=======================================
  Coverage   95.88%   95.88%           
=======================================
  Files         118      118           
  Lines        9397     9400    +3     
=======================================
+ Hits         9010     9013    +3     
  Misses        387      387           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@annawendler annawendler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please add one comment :)

cpp/models/ide_secir/parameters.h Show resolved Hide resolved
@annawendler annawendler merged commit f32c96d into main Feb 16, 2024
55 checks passed
@annawendler annawendler deleted the 898-change-test-for-valid-transition-distibution-from-ide-model branch February 16, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
class::bug Bugs found in the software loc::infrastructure General MEmilio Infrastructure related issues model::ide This issue concerns any kind of integro differential equations-based model. status::in review This issues is in review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change test for valid transition distribution from ide model
2 participants