-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
892 implement simple lct model #915
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #915 +/- ##
==========================================
+ Coverage 95.88% 95.99% +0.11%
==========================================
Files 118 124 +6
Lines 9397 9674 +277
==========================================
+ Hits 9010 9287 +277
Misses 387 387 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Martin J. Kühn <[email protected]>
Co-authored-by: Martin J. Kühn <[email protected]>
Co-authored-by: Martin J. Kühn <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, good work :)
@mknaranja I think this PR can lead to issues with PR #894. Do we wait until this is merged? |
@HenrZu @lenaploetzke We should advance both pull requests with review (and adaptations) at the same time and for the one to be merged later we should combine forces to not put to much on the shoulder of the persons who comes second ;) |
Co-authored-by: Henrik Zunker <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I made some comments, mainly regarding notation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No further comments from my side :)
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
If need be, add additional information and what the reviewer should look out for in particular:
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)
Closes #892.