Solve bug in solution.jl #521
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proposed solution for bug in solution.jl (Fixes SciML#514). The solution handles the case where the basis of the problem is empty which would throw the DimensionMismatch error.
| if size(b(prob)) == size(get_implicit_data(prob)) | ||
| rss = sum(abs2, get_implicit_data(prob) .- b(prob)) | ||
| else | ||
| rss = sum(abs2, get_implicit_data(prob)) |
There was a problem hiding this comment.
how is this the residual?
There was a problem hiding this comment.
I ran into the DimensionMismatch error while using DataDrivenSparse.jl. It seemed to occur when the basis is empty. I assumed that this would be analog to computing the residual to a vector of zeros. When there is no model to approximate the data, the residual can be seen as the data itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed solution for bug in solution.jl (Fixes #514). The solution handles the case where the basis of the problem is empty which would throw the DimensionMismatch error.