reinitialize DAEs in between calling callback.affect! and the second savevalues!
#997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This really should get a test. |
|
test added. |
Comment on lines
+223
to
+225
| #test that reinit happens for both FSAL and non FSAL integrators | ||
| @testset "dae re-init" for alg in [FBDF(), Rodas5P()] | ||
| sol = solve(prob, alg) |
There was a problem hiding this comment.
dae test added. That said, for extra fun, IDA fails to solve this because it does callbacks separately and wrong.
There was a problem hiding this comment.
Actually no, your code here is bad.
ChrisRackauckas
added a commit
that referenced
this pull request
Feb 6, 2024
Fixes the handling of #997
5 tasks
ChrisRackauckas
added a commit
that referenced
this pull request
Feb 9, 2024
Fixes the handling of #997
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.
fixes SciML/OrdinaryDiffEq.jl#2127