-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support conditional statements in @mtkmodel
#2319
Conversation
Should we also generate events here or lower @YingboMa ? |
I guess it depends on whether |
a32b0f0
to
2c1cdf8
Compare
2c1cdf8
to
53d609b
Compare
Bump |
The MTKStdlib failure looks real. Also, could you merge master back to this branch and run formatter? |
`@parameters`,`@variables`, `@components` in the `@mtkmodel` and `@components`.
…d conditional default values to parameters and variables
…ds compatible - all variables are added as a key and `:condition` is added as a metadata for the conditional variables. - The `:condition` contains entire if-else block info as a tuple of (condition-branch, condition, variables-if-correct, variable-if-condition-isn't-met). - variable-if-condition-isn't-met is nothing or tuple similar to the one above.
- and ternary conditional statements at the top level of the block - adds relevant tests
53d609b
to
8b75e01
Compare
@YingboMa I've rebased and have fixed issues that threw error in MTKStdlib tests. This can be reviewed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good!
This PR adds support for
@equations
@components
@parameters
and@variables