Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add component-based hybrid system test #2355

Merged
merged 8 commits into from
Jan 25, 2024
Merged

add component-based hybrid system test #2355

merged 8 commits into from
Jan 25, 2024

Conversation

baggepinnen
Copy link
Contributor

@baggepinnen baggepinnen commented Nov 15, 2023

This PR adds a test for a hybrid system constructed from components. It exposes a few problems:

  • There is a delay of exactly 1 sample interval in the output. I have not yet located the source of the delay. I think the problem is that d2c_view needs to be initialized correctly, it currently starts out as 0. Missing initialization of discrete-to-continuous communication parameter #2356
  • All variables associated with the discrete partition are zero in the solution, including observed variables
  • The fact that Hold is an operator precludes its use as a component with the same name. We could consider renaming the operator hold to avoid the conflict. The same goes for the operator Sample, but in this case I find the component name Sampler okay (whereas Holder isn't great 😅 )

I added some tests that are marked as broken are fixed, tracked by

Additionally, issue

@baggepinnen baggepinnen marked this pull request as ready for review November 15, 2023 12:30
@YingboMa
Copy link
Member

Tests passed locally for me.

@YingboMa YingboMa merged commit eb33a8a into master Jan 25, 2024
16 of 20 checks passed
@YingboMa YingboMa deleted the fb/discrete_timing branch January 25, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants