docs: update docs for MTKv9 #2489
Conversation
Doc examples also commented out, to be added when StructuralIndentifiability works with v9
|
Why is DynamicQuantities compat capped? |
| @@ -15,6 +15,57 @@ Symbolics.option_to_metadata_type(::Val{:irreducible}) = VariableIrreducible | |||
| Symbolics.option_to_metadata_type(::Val{:state_priority}) = VariableStatePriority | |||
| Symbolics.option_to_metadata_type(::Val{:misc}) = VariableMisc | |||
|
|
|||
| function dump_variable_metadata(var) | |||
There was a problem hiding this comment.
dump_variable_metadata(var) seems perfect to me. The named tuple return type allows direct integration with Tables.jl.
There was a problem hiding this comment.
Note that the returned NamedTuple may not have the same type or fields for all variables. It depends on the types of the symbolic variables themselves as well as the contained metadata
There was a problem hiding this comment.
Oh yeah, true. I don't think this is compatible with Tables.jl, but I definitely prefer this option that does not print unecessary informatioN!
| @@ -38,5 +34,5 @@ parammap = [ | |||
| ] | |||
|
|
|||
| prob = SDEProblem(de, u0map, (0.0, 100.0), parammap) | |||
| sol = solve(prob, SOSRI()) | |||
| sol = solve(prob, LambdaEulerHeun()) | |||
There was a problem hiding this comment.
@YingboMa is it not able to detect it's diagonal in the lowering process?
There was a problem hiding this comment.
Let's open an issue about this.
Also make `istunable` default to `true` for parameters without tunable metadata. `tunable_parameters` is also updated accordingly
AayushSabharwal
force-pushed
the
as/docs-v9
branch
from
0274d5d to
16d6311
Compare
|
This should be good to go. Forgot to squash the Docs still won't build because of |
|
|
Disable that for now, it's fixed in #2403 but we shouldn't wait |
Done |
AayushSabharwal
force-pushed
the
as/docs-v9
branch
from
ed1e686 to
02e6a24
Compare
AayushSabharwal
force-pushed
the
as/docs-v9
branch
from
02e6a24 to
9535ba7
Compare
Close #2059
Close #1968
Close #2481
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.