Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use subs_constants in generate_control_function #2904

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

aml5600
Copy link
Contributor

@aml5600 aml5600 commented Jul 29, 2024

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

In response to issue 2896

Adds a line to call subs_constants for each eq from full_equations. Test was added to verify it would fail before fix, and pass after.

@ChrisRackauckas ChrisRackauckas merged commit a7f6cd2 into SciML:master Jul 29, 2024
22 checks passed
@aml5600 aml5600 mentioned this pull request Aug 15, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants