-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error hint on Num in boolean context #2919
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+281
to
+288
println(io, "\nA symbolic expression appeared in a Boolean context. This error arises in situations where Julia expects a Bool, like ") | ||
printstyled(io, "if boolean_condition", color=:blue) | ||
printstyled(io, "\t\t use ifelse(boolean_condition, then branch, else branch)\n", color=:green) | ||
printstyled(io, "x && y", color=:blue) | ||
printstyled(io, "\t\t\t\t use x & y\n", color=:green) | ||
printstyled(io, "booelan_condition ? a : b", color=:blue) | ||
printstyled(io, "\t use ifelse(boolean_condition, a, b)\n", color=:green) | ||
print(io, "but a symbolic expression appeared instead of a Bool. For help regarding control flow with symbolic variables, see https://docs.sciml.ai/ModelingToolkit/dev/basics/FAQ/#How-do-I-handle-if-statements-in-my-symbolic-forms?") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
println(io, "\nA symbolic expression appeared in a Boolean context. This error arises in situations where Julia expects a Bool, like ") | |
printstyled(io, "if boolean_condition", color=:blue) | |
printstyled(io, "\t\t use ifelse(boolean_condition, then branch, else branch)\n", color=:green) | |
printstyled(io, "x && y", color=:blue) | |
printstyled(io, "\t\t\t\t use x & y\n", color=:green) | |
printstyled(io, "booelan_condition ? a : b", color=:blue) | |
printstyled(io, "\t use ifelse(boolean_condition, a, b)\n", color=:green) | |
print(io, "but a symbolic expression appeared instead of a Bool. For help regarding control flow with symbolic variables, see https://docs.sciml.ai/ModelingToolkit/dev/basics/FAQ/#How-do-I-handle-if-statements-in-my-symbolic-forms?") | |
println(io, | |
"\nA symbolic expression appeared in a Boolean context. This error arises in situations where Julia expects a Bool, like ") | |
printstyled(io, "if boolean_condition", color = :blue) | |
printstyled( | |
io, "\t\t use ifelse(boolean_condition, then branch, else branch)\n", | |
color = :green) | |
printstyled(io, "x && y", color = :blue) | |
printstyled(io, "\t\t\t\t use x & y\n", color = :green) | |
printstyled(io, "booelan_condition ? a : b", color = :blue) | |
printstyled(io, "\t use ifelse(boolean_condition, a, b)\n", color = :green) | |
print(io, | |
"but a symbolic expression appeared instead of a Bool. For help regarding control flow with symbolic variables, see https://docs.sciml.ai/ModelingToolkit/dev/basics/FAQ/#How-do-I-handle-if-statements-in-my-symbolic-forms?") |
This is the wrong repository. It's effectively piracy here. It should be in Symbolics.jl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use of a symbolic expression in a boolean context is a rather common user mistake, this PR adds a hint with possible fixes