Make screen_units work with Unitful #2947
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs a test |
|
Never mind, this happened because I used an independent variable with DynamicQuantities in a model with Unitful variables. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, constructing a model using Unitful results in many spurious warnings about missing units. This adds a check for any
Unitful.FreeUnitsand considers that a success.I'm not sure what the intent of this function is, and even for DynamicQuantities it seems too restrictive. One nice way to use units is to select a consistent set of units that scale the problem nicely, these may not be base SI units depending on the problem. The system should still be able to verify consistency over that nicely-scaled set of units. Why does this function reject anything but base SI units?