Hotfix to avoid DataFrames.jl piracy #2966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AayushSabharwal
approved these changes
Aug 14, 2024
|
The test failures are concerning though? |
|
Bump |
Closed
|
As far as I understand, this is good to go. Those tests appear to be the ones that were failing on other PRs as well, but I'm pulling the latest work from master, re-running CI and then comparing against #2974 |
MasonProtter
force-pushed
the
patch-3
branch
2 times, most recently
from
8edccd7 to
bf00b63
Compare
|
Failures are the same as master. This shouldn't really be able to break anything, because all it does is replace vcat(Equation[], pdeps)with pdeps |
|
The failure is due to the ConstructionBase breakage. |
|
I think it's not just that. There seems to be multiple other problems that Aayush is working on solving in #2973 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2965. This should not be necessary, but it solves the issue introduced by JuliaData/DataFrames.jl#3456
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.