Fix unit conversion for expressions #2998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a parameter is specified in terms of other parameters, no unit conversion should be attempted until the full expression is evaluted.
contradict
force-pushed
the
expression_unit_conversion
branch
from
e6ebe28 to
e078c1d
Compare
ChrisRackauckas
approved these changes
Aug 30, 2024
|
Hey mind if I ask for some help on https://github.com/JuliaSymbolics/Symbolics.jl/actions/runs/10632283882/job/29474928357#step:7:957 ? I haven't been able to get around to fixing the Symbolics downstream test and it's another one of these units oddities. If you have a second it look it might not even be hard and it might related to some of what you've already found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a parameter is specified in terms of other parameters, no unit conversion should be attempted until the full expression is evaluated.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.