Fix type promotion in InitializationProblem
s with vectors in the u0map
#3234
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
The current MTK breaks the docs example for MTKNN with
This is due to the type promotion for the
u0map
in the initialization problem, which usesuoT.(v)
, wherev isa AbstractArray
. Since theu0T
type is computed viatypeof
, we should broadcast theeltype
, not the full type.I don't have a MWE for this, I tried adjusting the existing test for vector initial conditions, but I can't get this to reach that code path.