expose quadratic form structure explicitly

SciML · Sep 14, 2023 · 332a3bf · 332a3bf
1 parent bf1b27d
commit 332a3bf
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/trustRegion.jl b/src/trustRegion.jl
@@ -458,7 +458,7 @@ function retrospective_step!(cache::TrustRegionCache{true})
     @unpack H, g, step_size = cache
 
     return -(get_loss(fu_prev) - get_loss(fu)) /
-           (step_size' * g + step_size' * H * step_size / 2)
+           (dot(step_size, g) + dot(step_size, H, step_size) / 2)
 end
 
 function retrospective_step!(cache::TrustRegionCache{false})
@@ -470,15 +470,15 @@ function retrospective_step!(cache::TrustRegionCache{false})
     @unpack H, g, step_size = cache
 
     return -(get_loss(fu_prev) - get_loss(fu)) /
-           (step_size' * g + step_size' * H * step_size / 2)
+           (dot(step_size, g) + dot(step_size, H, step_size) / 2)
 end
 
 function trust_region_step!(cache::TrustRegionCache)
     @unpack fu_new, step_size, g, H, loss, max_trust_r, radius_update_scheme = cache
     cache.loss_new = get_loss(fu_new)
 
     # Compute the ratio of the actual reduction to the predicted reduction.
-    cache.r = -(loss - cache.loss_new) / (step_size' * g + step_size' * H * step_size / 2)
+    cache.r = -(loss - cache.loss_new) / (dot(step_size, g) + dot(step_size, H, step_size) / 2)
     @unpack r = cache
 
     if radius_update_scheme === RadiusUpdateSchemes.Simple