Add Gauss Newton and make LM work for NLS Problems #207
Conversation
Codecov Report
@@ Coverage Diff @@
## master #207 +/- ##
==========================================
- Coverage 94.42% 93.55% -0.87%
==========================================
Files 7 8 +1
Lines 699 698 -1
==========================================
- Hits 660 653 -7
- Misses 39 45 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Should LeastSquaresProblem be its own problem type? |
That's actually a good point. I was thinking about this from a correctness standpoint. Currently if using a Nonlinear Solver for NLS, we will directly hit SteadyStateAdjoint which is clearly incorrect. |
|
Also, a LeastSquaresProblem could use other methods like Optimization.jl stuff. So it just seems like a prudent way to handle it. We should make Levenburg-Marquedt specialize on it too. Worth an issue, etc. |
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
|
Damn it. Messed up the history. I will open a new PR |
Don't merge it before #203