-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AD Section in Documentation #354
Conversation
d50f848
to
bb62c6c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #354 +/- ##
===========================================
- Coverage 86.19% 75.81% -10.39%
===========================================
Files 44 44
Lines 2608 2605 -3
===========================================
- Hits 2248 1975 -273
- Misses 360 630 +270 ☔ View full report in Codecov by Sentry. |
I want to verify that this is better in most cases before switching the default |
This reverts commit bb62c6c.
ee67a53
to
efa1c67
Compare
efa1c67
to
a5761d4
Compare
a5761d4
to
b04170e
Compare
e57428f
to
812f6fb
Compare
@oscardssmith do you know what https://github.com/SciML/NonlinearSolve.jl/actions/runs/7786112451/job/21230175067?pr=354#step:6:14951 is? It seems to come from the |
It is. It means you are trying to AD a function even though the test specifically tells you not to AD it. |
TODOs
Good Old Brusselator Benchmark
Not changing the default, here, but mentioned in the docs on how to use polyester.