-
-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Aliasing API #2503
Merged
+170
−111
Merged
Use Aliasing API #2503
Changes from 20 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
fd0646d
alias_u0 implementation
jClugstor 5cf41b0
add comment
jClugstor 0951540
add error for non ODEAliases alias
jClugstor 9666052
no space
jClugstor c5b2b9e
use ODEAliasSpecifier
jClugstor bb9b54d
fix aliasing
jClugstor 75449c2
change default for ODEAliasSpecifier in init
jClugstor 0454f1c
add use of alias_f, alias_p kwargs for ODiffEq
jClugstor bdaa141
fix defaults
jClugstor 4780e72
import ODEAliasSpecifier from SciMLBase
jClugstor 4d8ae15
fix f vs p
jClugstor cef2d29
account for defaults
jClugstor d2d5f61
tstop aliasing
jClugstor c23e54e
use recursivecopy, fix the default AliasSpecifier
jClugstor 78b1a97
fix depwarns
jClugstor b5657e9
make tests use aliasing API
jClugstor ec1e99f
add test
jClugstor b3351f0
can't use Accessors because no default inner constructors anymore
jClugstor 4feb5e3
add to run test
jClugstor ba9abe9
Update Project.toml
ChrisRackauckas 532c3ff
fix bool problem for alias_du0
jClugstor a2a2954
get rid of DAE problem, unused
jClugstor affbc14
nothing checking doesn't make sense here
jClugstor eacc432
fix test
jClugstor ac32012
require SciMLBase versions with AliasSpecifiers
jClugstor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Canonicalize this in the DifEqBase part?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what you mean. This is here so that if
alias = true
oralias = false
insolve
that gets passed to theODEAliasSpecifier
constructor so that every variable is aliased / not aliased.