Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for getu/setu in SII, add tests #582

Merged
merged 3 commits into from
Jan 4, 2024

Conversation

AayushSabharwal
Copy link
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@AayushSabharwal
Copy link
Member Author

Tests won't run until SII is tagged

@AayushSabharwal
Copy link
Member Author

This requires SciML/RecursiveArrayTools.jl#322

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (cd04572) 39.45% compared to head (ed57e16) 30.37%.
Report is 5 commits behind head on master.

Files Patch % Lines
src/integrator_interface.jl 0.00% 9 Missing ⚠️
src/problems/problem_interface.jl 0.00% 6 Missing ⚠️
src/solutions/solution_interface.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #582      +/-   ##
==========================================
- Coverage   39.45%   30.37%   -9.08%     
==========================================
  Files          53       53              
  Lines        4038     4039       +1     
==========================================
- Hits         1593     1227     -366     
- Misses       2445     2812     +367     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas
Copy link
Member

This requires SciML/RecursiveArrayTools.jl#322

Bump the version requirement

@ChrisRackauckas ChrisRackauckas merged commit c6d281f into SciML:master Jan 4, 2024
34 of 80 checks passed
@AayushSabharwal AayushSabharwal deleted the as/getu branch January 4, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants