Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm graspologic #1956

Merged
merged 1 commit into from
Feb 10, 2025
Merged

rm graspologic #1956

merged 1 commit into from
Feb 10, 2025

Conversation

emrgnt-cmplxty
Copy link
Contributor

@emrgnt-cmplxty emrgnt-cmplxty commented Feb 10, 2025

Important

Remove graspologic dependency and add lark in pyproject.toml, updating Python version compatibility.

  • Dependencies:
    • Remove graspologic from tool.poetry.dependencies and tool.poetry.extras.core.
    • Add lark to tool.poetry.dependencies and tool.poetry.extras.core.
    • Update Python version compatibility to >=3.10,<3.14 in tool.poetry.dependencies.

This description was created by Ellipsis for 6209294. It will automatically update as commits are pushed.

@emrgnt-cmplxty emrgnt-cmplxty marked this pull request as ready for review February 10, 2025 19:24
@emrgnt-cmplxty emrgnt-cmplxty merged commit 4eeb04d into main Feb 10, 2025
10 of 14 checks passed
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 6209294 in 1 minute and 14 seconds

More details
  • Looked at 47 lines of code in 1 files
  • Skipped 1 files when reviewing.
  • Skipped posting 6 drafted comments based on config settings.
1. py/pyproject.toml:30
  • Draft comment:
    Ensure the new Python upper bound (<3.14) is intentional and compatible with all dependencies.
  • Reason this comment was not posted:
    Marked as duplicate.
2. py/pyproject.toml:64
  • Draft comment:
    Confirm removal of graspologic and update codebase accordingly.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    The comment is asking the author to confirm the removal of a library, which is not allowed according to the rules. It doesn't provide a specific code suggestion or ask for a test to be written. Therefore, it should be removed.
3. py/pyproject.toml:157
  • Draft comment:
    Verify that graspologic's removal from extras is complete and doesn't affect any optional features.
  • Reason this comment was not posted:
    Marked as duplicate.
4. py/pyproject.toml:30
  • Draft comment:
    Updated Python version bound to <3.14; ensure compatibility with Python 3.13 and related dependencies.
  • Reason this comment was not posted:
    Marked as duplicate.
5. py/pyproject.toml:64
  • Draft comment:
    Removed 'graspologic'; verify that no code depends on it in both dependencies and extras.
  • Reason this comment was not posted:
    Marked as duplicate.
6. py/pyproject.toml:97
  • Draft comment:
    Added 'lark' dependency for ingestion; confirm that version '^1.1.8' is appropriate and its inclusion in extras is intentional.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 0% vs. threshold = 50%
    The rules explicitly state "Do NOT comment on dependency changes, library versions that you don't recognize, or anything else related to dependencies." Additionally, the rules say not to ask authors to confirm their intentions. This comment violates both rules.
    Perhaps the version or inclusion could cause compatibility issues that would be worth flagging? Maybe there's a security concern?
    The rules are clear that dependency-related comments should be avoided. If there were compatibility or security issues, they would be caught by the build process or dependency scanning tools.
    This comment should be deleted as it violates the rules about commenting on dependencies and asking authors to confirm their intentions.

Workflow ID: wflow_GRYc4u97zTC0Y73l


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@emrgnt-cmplxty emrgnt-cmplxty deleted the feature/rm-graspologic branch February 12, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant