Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add back generated answer #1965

Merged
merged 1 commit into from
Feb 11, 2025
Merged

add back generated answer #1965

merged 1 commit into from
Feb 11, 2025

Conversation

emrgnt-cmplxty
Copy link
Contributor

@emrgnt-cmplxty emrgnt-cmplxty commented Feb 11, 2025

Important

Uncomment generated_answer field in RAGResponse class to include generated completion from RAG process.

  • Models:
    • Uncomment generated_answer field in RAGResponse class in responses.py to include generated completion from RAG process.

This description was created by Ellipsis for c9cdbec. It will automatically update as commits are pushed.

@emrgnt-cmplxty emrgnt-cmplxty marked this pull request as ready for review February 11, 2025 07:43
@emrgnt-cmplxty emrgnt-cmplxty merged commit f0e2865 into main Feb 11, 2025
3 checks passed
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to c9cdbec in 23 seconds

More details
  • Looked at 17 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. py/shared/api/models/retrieval/responses.py:110
  • Draft comment:
    Re-enabled 'generated_answer'; consider removing the now-redundant 'completion' (deprecated) field if possible.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50%
    None
2. py/shared/api/models/retrieval/responses.py:110
  • Draft comment:
    Uncommenting the generated_answer field restores its functionality. Ensure its use remains consistent with the deprecated 'completion' field and update related examples/documentation as needed.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    The comment suggests ensuring consistency between the 'generated_answer' field and the deprecated 'completion' field, and updating related examples/documentation. This is a request for confirmation and updating documentation, which violates the rules.

Workflow ID: wflow_QjgxXV9BFC8mpA0v


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@emrgnt-cmplxty emrgnt-cmplxty deleted the patch/add-back-gen-answer branch February 12, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant