up #1966
Merged
up #1966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to e4bb2d1 in 53 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. py/shared/api/models/retrieval/responses.py:127
- Draft comment:
Remove commented-out deprecation flag. If deprecation is no longer needed, delete it rather than commenting it out. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_4A2ommPRCNrC0EGH
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -124,7 +124,7 @@ class RAGResponse(BaseModel): | |||
| completion: str = Field( | |||
| ..., | |||
| description="The generated completion from the RAG process", | |||
| deprecated=True, | |||
| # deprecated=True, | |||
There was a problem hiding this comment.
Remove commented-out deprecation flag. If the field is no longer deprecated, delete the commented code entirely rather than leaving it, or add a clarifying comment.
Suggested change
| # deprecated=True, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Removed
deprecated=Truecomment fromcompletionfield inRAGResponseclass inresponses.py.RAGResponseclass, removeddeprecated=Truecomment fromcompletionfield inresponses.py.This description was created by
for e4bb2d1. It will automatically update as commits are pushed.