feat(device-loader): Extract more agnostic stuff from native impl #9746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FirelightFlagboy
force-pushed
the
extract-more-agnostic-load-device
branch
3 times, most recently
from
6757924 to
36e7b2f
Compare
mmmarcos
reviewed
Feb 24, 2025
touilleMan
reviewed
Feb 27, 2025
FirelightFlagboy
force-pushed
the
extract-more-agnostic-load-device
branch
2 times, most recently
from
597e914 to
e6f46ce
Compare
touilleMan
reviewed
Feb 28, 2025
| @@ -7,6 +7,7 @@ homepage.workspace = true | |||
| license.workspace = true | |||
| version.workspace = true | |||
| repository.workspace = true | |||
| autotests = false | |||
There was a problem hiding this comment.
I'd rather stay consistent since we don't do this with the other crates
Can you instead create a tests/unit/ folder containing all the tests files (and the mod.rs you added)
touilleMan
approved these changes
Feb 28, 2025
Co-authored-by: Marcos Medrano <[email protected]>
FirelightFlagboy
force-pushed
the
extract-more-agnostic-load-device
branch
2 times, most recently
from
c8776cf to
cc639b8
Compare
FirelightFlagboy
force-pushed
the
extract-more-agnostic-load-device
branch
from
cc639b8 to
bfb83a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.