Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix platform_device_loader tests #9804

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix platform_device_loader tests #9804

wants to merge 3 commits into from

Conversation

touilleMan
Copy link
Member

@touilleMan touilleMan commented Feb 24, 2025 •
edited
Loading

close #8357
close #8356

@touilleMan touilleMan requested a review from a team as a code owner February 24, 2025 10:50
FirelightFlagboy
FirelightFlagboy requested changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@FirelightFlagboy FirelightFlagboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate of #9594 for list_devices test

@touilleMan
Copy link
Member Author

Ha ! my bad 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FirelightFlagboy FirelightFlagboy FirelightFlagboy requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix platform_device_loader tests Remove #[allow(unused)] for platform_device_loader::save_device
2 participants
@touilleMan @FirelightFlagboy