Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MS] Responsive menu #9805

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[MS] Responsive menu #9805

wants to merge 2 commits into from

Conversation

fabienSvtr
Copy link
Contributor

@fabienSvtr fabienSvtr commented Feb 24, 2025

Describe your changes

This PR adds the responsive behaviour for the menu, updating the sidebarMenu into a tabsMenu.
I also added the mixin in scss to manage breakpoints between pages.

responsive.menu.mov

Checklist

Before you submit this pull request, please make sure to:

  • Keep changes in the pull request as small as possible
  • Ensure the commit history is sanitized
  • Give a meaningful title to your PR
  • Describe your changes
  • Link any related issue in the description
  • Link any dependent pull request in the description

closes #9509

@fabienSvtr fabienSvtr changed the title Ms responsive menu [MS] Responsive menu Feb 24, 2025
@fabienSvtr fabienSvtr marked this pull request as ready for review February 25, 2025 07:12
@fabienSvtr fabienSvtr requested a review from a team as a code owner February 25, 2025 07:12
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add an ultrawide breakpoint at something like 1920

Copy link
Contributor

@NicoTuxx NicoTuxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabienSvtr Good for now, but:

  • mixins should be moved to megashark-lib: Open an issue to track it and good for merge
  • around 1040px (under) the resize bar does not work on the sidebar menu

@fabienSvtr fabienSvtr force-pushed the ms-responsive-menu branch 2 times, most recently from e63a404 to f0e1394 Compare February 26, 2025 07:48
}

onMounted(async () => {
const infoResult = await parsecGetClientInfo();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: Does this list/load of available device?

@fabienSvtr
Copy link
Contributor Author

fabienSvtr commented Feb 26, 2025

@fabienSvtr Good for now, but:

  • mixins should be moved to megashark-lib: Open an issue to track it and good for merge
  • around 1040px (under) the resize bar does not work on the sidebar menu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MS] Responsive - Tab-bar menu & adding dropdown
4 participants