-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MS] Responsive menu #9805
base: master
Are you sure you want to change the base?
[MS] Responsive menu #9805
Conversation
6a22b5e
to
be6c0f4
Compare
c99cbb9
to
99c5f30
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add an ultrawide breakpoint at something like 1920
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fabienSvtr Good for now, but:
- mixins should be moved to megashark-lib: Open an issue to track it and good for merge
- around 1040px (under) the resize bar does not work on the sidebar menu
e63a404
to
f0e1394
Compare
} | ||
|
||
onMounted(async () => { | ||
const infoResult = await parsecGetClientInfo(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: Does this list/load of available device?
bc8d25e
to
7ac9b24
Compare
|
Describe your changes
This PR adds the responsive behaviour for the menu, updating the sidebarMenu into a tabsMenu.
I also added the mixin in scss to manage breakpoints between pages.
responsive.menu.mov
Checklist
Before you submit this pull request, please make sure to:
closes #9509