feat(server): Add function to check if service request is authenticated #9806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
server/parsec/config.py
Outdated
Comment on lines
200
to
201
| # Bearer token used to authenticate the service API | ||
| service_token: str |
There was a problem hiding this comment.
note: By service we mainly mean the API that will use parsec-auth.
It's different from admin-token since the operation done by parsec-auth are read-only
FirelightFlagboy
force-pushed
the
service-auth-req
branch
from
981f226 to
85f08ed
Compare
AureliaDolo
approved these changes
Feb 24, 2025
2 tasks
touilleMan
reviewed
Feb 25, 2025
| @@ -43,6 +43,7 @@ def backend_config( | |||
| email_config=MockedEmailConfig("[email protected]", tmpdir), | |||
| blockstore_config=blockstore_config, | |||
| administration_token="s3cr3t", | |||
| service_token="P4ssw0rd", | |||
There was a problem hiding this comment.
Suggested change
| service_token="P4ssw0rd", | |
| service_token="s3rv1c3", |
P4ssw0rd as token is a bit weird...
| @@ -197,6 +197,9 @@ class BackendConfig: | |||
|
|
|||
| # Bearer token used to authenticate the administration API | |||
| administration_token: str | |||
| # Bearer token used to authenticate the service API | |||
| # If not defined, the API is not accessible | |||
| service_token: str | None = None | |||
There was a problem hiding this comment.
What is this service API ?
If we end up with two unrelated APIs both using a token, we must further document what each of them are for.
FirelightFlagboy
force-pushed
the
service-auth-req
branch
from
85f08ed to
b42a8bd
Compare
FirelightFlagboy
force-pushed
the
service-auth-req
branch
from
b42a8bd to
ac3a4d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.