Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add job to lint posts on push and PR #281

Merged
merged 3 commits into from
Nov 29, 2024

Conversation

dogle-scottlogic
Copy link
Contributor

  • Update npm test to be "lint"
  • Add a workflow action to run the lint on push and PR to gh-pages
  • Update the a11y workflow to run on all PRs to gh-pages

Copy link
Member

@chriswilty chriswilty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good with a couple of small changes.

.circleci/config.yml Outdated Show resolved Hide resolved
.github/workflows/check-a11y-of-changed-content.yaml Outdated Show resolved Hide resolved
.github/workflows/lint.yaml Outdated Show resolved Hide resolved
.github/workflows/lint.yaml Outdated Show resolved Hide resolved
Copy link
Member

@chriswilty chriswilty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine now. I'd love to get an answer on that circleci config file though...

@chriswilty chriswilty merged commit 3ce082c into ScottLogic:gh-pages Nov 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants