-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add job to lint posts on push and PR #281
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dogle-scottlogic
commented
Nov 21, 2024
- Update npm test to be "lint"
- Add a workflow action to run the lint on push and PR to gh-pages
- Update the a11y workflow to run on all PRs to gh-pages
dogle-scottlogic
force-pushed
the
linting
branch
from
November 21, 2024 10:22
d835f9a
to
ecab390
Compare
dogle-scottlogic
force-pushed
the
linting
branch
from
November 21, 2024 10:24
ecab390
to
742130d
Compare
dogle-scottlogic
force-pushed
the
linting
branch
from
November 21, 2024 10:25
742130d
to
478bc4f
Compare
dogle-scottlogic
force-pushed
the
linting
branch
from
November 21, 2024 11:09
478bc4f
to
9e2ae11
Compare
chriswilty
requested changes
Nov 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be good with a couple of small changes.
chriswilty
reviewed
Nov 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine now. I'd love to get an answer on that circleci config file though...
chriswilty
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.