-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vuu 47 link layout provider and layout manager provider #58
Vuu 47 link layout provider and layout manager provider #58
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the code here looks great. I like the whole Provider/LayoutManager structure. I'm not going to micro-review individual lines. There is one important issue that would stop me merging yet.
What we save when we save a layout is not the current layout - we're saving the full JSON representation of all the loaded layouts. Thus when I load a layout from the layout browser, rather than adding that layout as a child of main-tabs, we replace the whole app layout.
Probably need a function to extract the currently selected layout (ie the Tab of main-tabs from which the menu action was activated) and one to add a layout to the existing structure (we have code for both these things in the layout reducer in layout package.
I should be able to wrap the sample-app and sample basket trading app with a LayoutManagerProvider and they should 'just work' . One does and one doesn't. Again, I think its because of exactly what we're saving
vuu-ui/packages/vuu-layout/src/layout-persistence/LayoutPersistenceManager.ts
Outdated
Show resolved
Hide resolved
vuu-ui/packages/vuu-layout/src/layout-persistence/LayoutPersistenceManager.ts
Outdated
Show resolved
Hide resolved
vuu-ui/packages/vuu-shell/src/layout-management/useLayoutManager.tsx
Outdated
Show resolved
Hide resolved
…UU-47-link-layoutProvider-and-layoutManagerProvider
vuu-ui/packages/vuu-layout/src/layout-persistence/LayoutPersistenceManager.ts
Outdated
Show resolved
Hide resolved
vuu-ui/packages/vuu-layout/src/layout-persistence/LocalLayoutPersistenceManager.ts
Outdated
Show resolved
Hide resolved
vuu-ui/packages/vuu-shell/src/layout-management/useLayoutManager.tsx
Outdated
Show resolved
Hide resolved
vuu-ui/packages/vuu-shell/src/layout-management/useLayoutManager.tsx
Outdated
Show resolved
Hide resolved
vuu-ui/packages/vuu-layout/src/layout-persistence/LayoutPersistenceManager.ts
Outdated
Show resolved
Hide resolved
…UU-47-link-layoutProvider-and-layoutManagerProvider
…tenceManager.ts Co-authored-by: Cara <[email protected]>
…https://github.com/ScottLogic/finos-vuu into VUU-47-link-layoutProvider-and-layoutManagerProvider
Changes
Bonus Feature: Saved Layouts can now be opened:
